Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jint 3.1.0 #15730

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Jint 3.1.0 #15730

merged 4 commits into from
Apr 16, 2024

Conversation

@Piedone
Copy link
Member

Piedone commented Apr 11, 2024

Just to be sure: did you test it? :)

@Skrypt
Copy link
Contributor

Skrypt commented Apr 11, 2024

We have unit tests for the JavaScriptEngine. That one at least has some.

@hishamco
Copy link
Member

Seems I will take the responsibility to add a functional test for almost the things in the framework :)

@Skrypt
Copy link
Contributor

Skrypt commented Apr 12, 2024

Or let's start asking functional tests or unit test with each PR's if they are missing. I think that's where we are at.

@Piedone
Copy link
Member

Piedone commented Apr 12, 2024

I'll follow up on automated QA, because we absolutely need to do more on that front. However, for now, as a PR author everyone should make sure that their code doesn't break anything (I mean, I hope this is not controversial).

@agriffard
Copy link
Member Author

There was an error during the build :

/home/runner/work/OrchardCore/OrchardCore/src/OrchardCore/OrchardCore.Configuration.KeyVault/OrchardCore.Configuration.KeyVault.csproj : error NU1902: Warning As Error: Package 'Azure.Identity' 1.10.4 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-wvxc-855f-jvrv [/home/runner/work/OrchardCore/OrchardCore/OrchardCore.sln]
  Failed to restore /home/runner/work/OrchardCore/OrchardCore/src/OrchardCore/OrchardCore.Configuration.KeyVault/OrchardCore.Configuration.KeyVault.csproj (in 95 ms).

@agriffard
Copy link
Member Author

agriffard commented Apr 13, 2024

I merged main on this branch and it fixed it.

@lahma
Copy link
Contributor

lahma commented Apr 14, 2024

3.1 broke some advanced API signatures (preparing AST method's input and output types) so if the code still compiles, it should work as before (at least Jint's +60 000 tests still pass 😉).

@Piedone
Copy link
Member

Piedone commented Apr 16, 2024

Thanks, @lahma! So, Antoine, did you test it?

@agriffard
Copy link
Member Author

Thanks, @lahma! So, Antoine, did you test it?

I tested with TheBlogTheme recipe, add a layer with a Javascript condition.
The widget I add in the Footer zone, associated to this layer, is displayed if the condition is true and not displayed if the condition returned value is false.

@lahma
Copy link
Contributor

lahma commented Apr 16, 2024

Honestly folks, this release ain't that evil 😆 We incremented the version to warn about the possible compilation time breaking change. It's probably basically 3.0.2 -> 3.0.3 for you.

@Piedone Piedone merged commit 2b84c66 into main Apr 16, 2024
5 checks passed
@Piedone Piedone deleted the ag/Jint3.1.0 branch April 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants